-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource Modifier should support json merge patch and strategic merge patch #6728
Comments
#6344 |
I think they are different things, jq can not cover the capabilities which json merge patch or strategic merge patch can provide |
@reasonerjt I want to implement this feature, can you assign it to me? |
@27149chen I think it would be great if you could pick impl. I can assign it to you. Had put further points on this, I am trying to see if through whatever enhancements we do to resource modifiers, we are also able to support scenarios in #6344 |
Reopen it as the implementation isn't merged |
Describe the problem/challenge you have
Resource Modifier uses json patch to patch object, but json patch is not easy to use and has limitations.
For example:
{"metadata":{"annotations":{"foo":null}}}
)Describe the solution you'd like
support json merge patch and strategic merge patch in Resource Modifier
Anything else you would like to add:
Environment:
velero version
):kubectl version
):/etc/os-release
):Vote on this issue!
This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.
The text was updated successfully, but these errors were encountered: