Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Changing PVC selected-node feature #7904

Closed
Lyndon-Li opened this issue Jun 19, 2024 · 1 comment
Closed

Deprecate Changing PVC selected-node feature #7904

Lyndon-Li opened this issue Jun 19, 2024 · 1 comment
Assignees
Labels
Breaking change Impacts backwards compatibility doc-change-required
Milestone

Comments

@Lyndon-Li
Copy link
Contributor

The Changing PVC selected-node feature is not required and not working well, so we need to deprecate it. Details as below:

  1. It is not required --- the feature was used to fix a limitation of old Kubernetes versions, but since Kubernetes 1.16, the limitation has been fixed
  2. It conflicts with the principle of WaitForFirstConsumer, so it doesn't work with WaitForFirstConsumer mode volume
  3. From the description here, the volume.kubernetes.io/selected-node annotation is an output of the scheduler, so changing it is more like a hack
@reasonerjt
Copy link
Contributor

reasonerjt commented Jun 21, 2024

In v1.15 let's just print a warning and add a document.
According to the process, we'll remove it in n+2, i.e. v1.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change Impacts backwards compatibility doc-change-required
Projects
None yet
Development

No branches or pull requests

2 participants