Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make node agent configMap name configurable #8032

Closed
Lyndon-Li opened this issue Jul 22, 2024 · 0 comments
Closed

Make node agent configMap name configurable #8032

Lyndon-Li opened this issue Jul 22, 2024 · 0 comments
Assignees
Labels
Breaking change Impacts backwards compatibility doc-change-required
Milestone

Comments

@Lyndon-Li
Copy link
Contributor

Lyndon-Li commented Jul 22, 2024

At present, Velero node-agent server searches the configMap with name hard coded node-agent-config for node agent configurations, i.e., affinities, concurrency, etc.

To make it more controllable and consistent, we want to apply below policies to the configMaps for Velero:

  1. The configMap name must be specified to the velero/node-agent server parameters through installation
  2. If the configMap name is specified but the configMap doesn't exist, it is ignored
  3. If the configMap name is not specified, the configMap will not be used

Therefore, we need to make the node-agent configMap name configurable in the server parameters and we also need to change the document.

@Lyndon-Li Lyndon-Li self-assigned this Jul 22, 2024
@Lyndon-Li Lyndon-Li added this to the v1.15 milestone Jul 22, 2024
@Lyndon-Li Lyndon-Li added the Breaking change Impacts backwards compatibility label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change Impacts backwards compatibility doc-change-required
Projects
None yet
Development

No branches or pull requests

1 participant