Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable pull policy when velero install #8457

Open
kaovilai opened this issue Nov 25, 2024 · 2 comments
Open

Configurable pull policy when velero install #8457

kaovilai opened this issue Nov 25, 2024 · 2 comments
Assignees
Labels
Area/CLI related to the command-line interface backlog

Comments

@kaovilai
Copy link
Member

Describe the problem/challenge you have

I would like pull policy to be configurable with velero install

pullPolicy := corev1.PullAlways
imageParts := strings.Split(c.image, ":")
if len(imageParts) == 2 && imageParts[1] != "latest" {
pullPolicy = corev1.PullIfNotPresent
}

Describe the solution you'd like

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@kaovilai kaovilai added Area/CLI related to the command-line interface backlog labels Nov 25, 2024
@kaovilai
Copy link
Member Author

Scenario is I build and run a dev image reusing tag. The tag is not latest, so I need to use pullAlways for changes to affect.

@kaovilai
Copy link
Member Author

kaovilai commented Dec 4, 2024

For those wondering how I use velero install currently and how this flag would help.

❯ alias velero-goruninstall-node-agent
velero-goruninstall-node-agent='velero-makecontainer-cluster-arch; go run cmd/velero/velero.go install --use-node-agent --image=$(ghcr_notag):$(current-branch)-$(rev-sha-short)-$(cluster-arch-only) --provider aws --bucket $AWS_BUCKET --prefix velero --plugins velero/velero-plugin-for-aws:latest --secret-file $AWS_SECRET_FILE'

See details at github.com/kaovilai/dotfiles

@kaovilai kaovilai self-assigned this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/CLI related to the command-line interface backlog
Projects
None yet
Development

No branches or pull requests

1 participant