Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

velero install should update existing velero deployment if any. #8458

Open
kaovilai opened this issue Nov 25, 2024 · 2 comments
Open

velero install should update existing velero deployment if any. #8458

kaovilai opened this issue Nov 25, 2024 · 2 comments
Assignees
Labels
Area/CLI related to the command-line interface backlog

Comments

@kaovilai
Copy link
Member

What steps did you take and what happened:

On velero install

Deployment/velero: already exists, proceeding

is logged.

When using install command alongside a new --image <>, new image was not applied to deployment.

Attempt to patch when isalreadyexists

if _, err := c.Create(r); apierrors.IsAlreadyExists(err) {
log("already exists, proceeding")

What did you expect to happen:

The following information will help us better understand what's going on:

If you are using velero v1.7.0+:
Please use velero debug --backup <backupname> --restore <restorename> to generate the support bundle, and attach to this issue, more options please refer to velero debug --help

If you are using earlier versions:
Please provide the output of the following commands (Pasting long output into a GitHub gist or other pastebin is fine.)

  • kubectl logs deployment/velero -n velero
  • velero backup describe <backupname> or kubectl get backup/<backupname> -n velero -o yaml
  • velero backup logs <backupname>
  • velero restore describe <restorename> or kubectl get restore/<restorename> -n velero -o yaml
  • velero restore logs <restorename>

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Velero features (use velero client config get features):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@kaovilai kaovilai self-assigned this Nov 25, 2024
@kaovilai kaovilai added Area/CLI related to the command-line interface backlog labels Nov 25, 2024
@ywk253100
Copy link
Contributor

I suggest we be cautious for such changes, this may cause unexpected behaviors in upgrading cases.
For example, if the Velero image is updated but the CRDs are not, this causes inconsistent.

@kaovilai
Copy link
Member Author

kaovilai commented Dec 2, 2024

This was for development convenience.. if it were to be implemented it could be behind dev or other override flag where it would also change CRDs.. essentially uninstall + install.

Alternative is to have a reinstall option that functions like install but runs uninstall first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/CLI related to the command-line interface backlog
Projects
None yet
Development

No branches or pull requests

2 participants