Proposal to support JSON Merge Patch and Strategic Merge Patch in Resource Modifiers #6797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6797 +/- ##
==========================================
+ Coverage 60.45% 60.78% +0.32%
==========================================
Files 242 245 +3
Lines 26031 26255 +224
==========================================
+ Hits 15738 15960 +222
+ Misses 9187 9164 -23
- Partials 1106 1131 +25 |
anshulahuja98
added
the
1.13-candidate
reasonerjt
removed
the
1.13-candidate
anshulahuja98
requested changes
Sep 21, 2023
anshulahuja98
requested changes
Sep 22, 2023
…ource Modifiers Signed-off-by: lou <[email protected]>
Signed-off-by: lou <[email protected]>
Signed-off-by: lou <[email protected]>
Signed-off-by: lou <[email protected]>
Signed-off-by: lou <[email protected]>
Signed-off-by: lou <[email protected]>
27149chen
force-pushed
the
rm-improvement-design
branch
from
df0aeed to
21a76c4
Compare
ywk253100
reviewed
Sep 25, 2023
ywk253100
approved these changes
Sep 25, 2023
anshulahuja98
approved these changes
Sep 26, 2023
| No security impact. | ||
|
|
||
| ## Compatibility | ||
| Compatible with current Resource Modifiers. |
There was a problem hiding this comment.
Maybe also mention about the compatibility with the existing RestoreItemAction plugins
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a summary of your change
Proposal to support JSON Merge Patch and Strategic Merge Patch in Resource Modifiers
Does your change fix a particular issue?
Fixes #6728
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.