Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot leak for backup #7558

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

qiuming-best
Copy link
Contributor

@qiuming-best qiuming-best commented Mar 25, 2024

Thank you for contributing to Velero!

Please add a summary of your change

  • Enable fail fast for kopia
  • Record snapshot id for failed backup

Does your change fix a particular issue?

Fixes #(issue)
#7503

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@qiuming-best qiuming-best force-pushed the uploader-fast-fail branch 2 times, most recently from 9db4e24 to 7eed91a Compare March 25, 2024 08:18
@qiuming-best qiuming-best force-pushed the uploader-fast-fail branch 4 times, most recently from 212f377 to df02992 Compare March 26, 2024 05:08
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 61.86%. Comparing base (3d6dab0) to head (3d5282e).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/controller/pod_volume_backup_controller.go 12.50% 7 Missing ⚠️
pkg/uploader/provider/kopia.go 54.54% 4 Missing and 1 partial ⚠️
pkg/controller/data_upload_controller.go 25.00% 2 Missing and 1 partial ⚠️
pkg/uploader/kopia/snapshot.go 50.00% 2 Missing and 1 partial ⚠️
pkg/cmd/cli/nodeagent/server.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7558      +/-   ##
==========================================
+ Coverage   61.84%   61.86%   +0.01%     
==========================================
  Files         265      266       +1     
  Lines       29356    29375      +19     
==========================================
+ Hits        18155    18172      +17     
- Misses       9913     9916       +3     
+ Partials     1288     1287       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiuming-best qiuming-best force-pushed the uploader-fast-fail branch 3 times, most recently from a5448d8 to 205971a Compare March 26, 2024 07:09
@qiuming-best qiuming-best changed the title [WIP] Add fast fail support and fix snapshot leak Add fast fail support and fix snapshot leak Mar 26, 2024
@qiuming-best qiuming-best changed the title Add fast fail support and fix snapshot leak Add fail fast support and fix snapshot leak Mar 26, 2024
@qiuming-best qiuming-best force-pushed the uploader-fast-fail branch 7 times, most recently from 88bb8d8 to d9f2c2d Compare March 29, 2024 01:57
@qiuming-best qiuming-best changed the title Add fail fast support and fix snapshot leak Fix snapshot leak for backup Mar 29, 2024
pkg/uploader/provider/kopia.go Outdated Show resolved Hide resolved
pkg/uploader/kopia/snapshot.go Outdated Show resolved Hide resolved
@qiuming-best qiuming-best force-pushed the uploader-fast-fail branch 2 times, most recently from fb62af8 to d8beb74 Compare April 1, 2024 01:59
@qiuming-best qiuming-best merged commit 3465e8c into vmware-tanzu:main Apr 1, 2024
65 of 66 checks passed
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Apr 2, 2024
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Apr 2, 2024
@danfengliu danfengliu added the Needs Testing If you've tested your change but would still like a maintainer to try it in a different environment label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-changelog has-unit-tests Needs Testing If you've tested your change but would still like a maintainer to try it in a different environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants