Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot: support github-actions updates #7594

Merged

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Mar 29, 2024

Please add a summary of your change

dependabot: support github-actions updates

Does your change fix a particular issue?

Fixes #6628

This will also help fix warning from github-actions like :

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/labeler@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Or even worse:

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/labeler@v3. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@mmorel-35 mmorel-35 force-pushed the dependabot/github-actions branch from 2e20a52 to 6b9eb11 Compare March 29, 2024 19:22
@mmorel-35 mmorel-35 marked this pull request as ready for review March 29, 2024 19:22
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.84%. Comparing base (3d6dab0) to head (b52b0a9).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7594   +/-   ##
=======================================
  Coverage   61.84%   61.84%           
=======================================
  Files         265      265           
  Lines       29356    29356           
=======================================
  Hits        18155    18155           
  Misses       9913     9913           
  Partials     1288     1288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mateusoliveira43
Copy link
Contributor

please link issue #6628

@mmorel-35 mmorel-35 force-pushed the dependabot/github-actions branch from 6b9eb11 to b52b0a9 Compare March 30, 2024 13:05
@qiuming-best
Copy link
Contributor

qiuming-best commented Apr 1, 2024

@mmorel-35 Sorry, I'm not sure how these configurations work in your PR.

Is it that if we enable github-actions dependencies update, once some actions use node.js or some other dependencies in the environment it will check and install the latest dependencies?

If we didn't enable it, actions will use the default dependencies in the environment?

@mmorel-35
Copy link
Contributor Author

Once this is merged it will create PR for your github actions. What I meant is that the github actions in velero are not up to date with dependabot the project will receive PR (checked once a week in the proposed configuration) for each new version of a github action.
I have enabled this on my fork, please have a look to see what this does.
Of course each maintainer of the used action is responsible for updating to the most recent node version. And I believe it's already done by most of them.

@qiuming-best
Copy link
Contributor

@blackpiglet @ywk253100 Please also help to evaluate the effect when enabling the github-actions updates.

@qiuming-best qiuming-best requested a review from blackpiglet April 8, 2024 08:34
@qiuming-best qiuming-best merged commit b755433 into vmware-tanzu:main Apr 9, 2024
66 checks passed
@mmorel-35 mmorel-35 deleted the dependabot/github-actions branch April 9, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable dependabot for github actions again?
5 participants