Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backup log to show error string, not index #7805

Merged
merged 2 commits into from
May 21, 2024

Conversation

piny940
Copy link
Contributor

@piny940 piny940 commented May 18, 2024

Thank you for contributing to Velero!

Please add a summary of your change

There was a mistake in golang range.
Since errs's type is []string in this case, the code should be:

for _, err := range errs {
...
}

Does your change fix a particular issue?

No issue, but this is related to discussion #7800

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: piny940 <[email protected]>
@Lyndon-Li Lyndon-Li added this to the v1.14 milestone May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.67%. Comparing base (f654188) to head (059effc).

Files Patch % Lines
pkg/controller/backup_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7805   +/-   ##
=======================================
  Coverage   58.67%   58.67%           
=======================================
  Files         345      345           
  Lines       28743    28743           
=======================================
  Hits        16866    16866           
  Misses      10448    10448           
  Partials     1429     1429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet merged commit 49eab81 into vmware-tanzu:main May 21, 2024
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants