[cherry-pick][release-1.14]Check whether the namespaces specified in namespace filter exist. #7998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check whether the namespaces specified in the backup.Spec.IncludeNamespaces exist during backup resource collcetion If not, log error to mark the backup as PartiallyFailed. Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
force-pushed
the
7928_fix_1.14
branch
from
4fffab2 to
57377f9
Compare
shubham-pampattiwar
approved these changes
Jul 11, 2024
blackpiglet
requested review from
ywk253100 and
Lyndon-Li
and removed request for
qiuming-best
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.14 #7998 +/- ##
================================================
- Coverage 58.81% 58.81% -0.01%
================================================
Files 346 346
Lines 28818 28816 -2
================================================
- Hits 16949 16947 -2
Misses 10438 10438
Partials 1431 1431 ☔ View full report in Codecov by Sentry. |
kaovilai
approved these changes
Jul 11, 2024
Lyndon-Li
approved these changes
Jul 12, 2024
blackpiglet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check whether the namespaces specified in the
backup.Spec.IncludeNamespaces exist during backup resource collcetion If not, log error to mark the backup as PartiallyFailed.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #7928
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.