Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.14] Avoid wrapping failed PVB status with empty message. #8037

Conversation

mrnold
Copy link
Contributor

@mrnold mrnold commented Jul 22, 2024

Please add a summary of your change

Cherry-pick of #8028 to the release-1.14 branch, removes a ':' from the start of failed PVB status message.

Does your change fix a particular issue?

Fixes #7857

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet requested review from blackpiglet and removed request for qiuming-best July 24, 2024 06:56
@blackpiglet
Copy link
Contributor

Could you help to rebase the branch with release-1.14?
@mrnold

mrnold added 2 commits July 24, 2024 09:21
Also change "get" to "found" as requested in issue vmware-tanzu#7857.

Signed-off-by: Matthew Arnold <[email protected]>
Signed-off-by: Matthew Arnold <[email protected]>
@mrnold mrnold force-pushed the pod-volume-message-7857-1.14 branch from b3a394f to 76a3ecc Compare July 24, 2024 13:22
@mrnold
Copy link
Contributor Author

mrnold commented Jul 24, 2024

@blackpiglet Okay, I rebased on top of the latest release-1.14.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.77%. Comparing base (ebafe12) to head (76a3ecc).

Files Patch % Lines
pkg/controller/pod_volume_backup_controller.go 0.00% 4 Missing ⚠️
pkg/cmd/cli/nodeagent/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.14    #8037      +/-   ##
================================================
- Coverage         58.77%   58.77%   -0.01%     
================================================
  Files               346      346              
  Lines             28821    28824       +3     
================================================
  Hits              16940    16940              
- Misses            10452    10455       +3     
  Partials           1429     1429              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubham-pampattiwar shubham-pampattiwar merged commit cd601ca into vmware-tanzu:release-1.14 Jul 24, 2024
64 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants