Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a native diff component #50

Open
mathewpareles opened this issue Sep 22, 2024 · 1 comment · May be fixed by #139
Open

Create a native diff component #50

mathewpareles opened this issue Sep 22, 2024 · 1 comment · May be fixed by #139
Labels
high priority 🚀 High priority issue

Comments

@mathewpareles
Copy link
Contributor

mathewpareles commented Sep 22, 2024

When the user applies changes to a file, Void will highlight all of the additions in green. Here's an example:

green.diffs.mp4

However, Void should also display the parts of the file that were deleted. Here's a mock-up of what we want this to look like for the above example. The diff should include both the insertions (green) and deletions (red):

expected-diff

Task: Show diffs as above. This requires creating a new provider for diffs diffProvider, and using it in Void's VS Code extension.

Constraints:

  1. When a diff is displayed, it should not cause a syntax error in the file.
  2. When the user selects everything in the file (ctrl + a), the deletion parts of diffs should not be included in their selection.
@andrewpareles
Copy link
Contributor

#119 starts this

@andrewpareles andrewpareles removed the good first issue Good for newcomers label Oct 28, 2024
@andrewpareles andrewpareles unpinned this issue Oct 28, 2024
@andrewpareles andrewpareles added high priority 🚀 High priority issue and removed new feature New feature or request help wanted Extra attention is needed labels Oct 28, 2024
@andrewpareles andrewpareles linked a pull request Nov 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority 🚀 High priority issue
Projects
Status: Important
Development

Successfully merging a pull request may close this issue.

2 participants