-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google has depreciated sha1 for certs #36
Comments
@cjeanneret care to comment on that? |
Pull request for this above, this change is working for me. I was trying to write a test to verify this behaviour, however as it is handled inside the openssl binary we can't simply trap the existing calls as best I can tell. I'd need to re-open the file and verify the signature, and it was not clear for me how to do this. If someone can guide me to running a command and verifying the output I'd gladly add it in. Example verification: In the mean time if you want to work around this issue, you can simply clone cert.cnf.erb into your module/manifest, and then pass cnf_tpl to openssl::certificate::x509 |
No real meaning for a unit-test on this particular point. It might have been a variable though, but enforcing good practices is better. |
Thanks for merging, and the notes about the test. |
Google Chrome will stop trusting SHA1 after Jan 2017:
http://googleonlinesecurity.blogspot.com/2014/09/gradually-sunsetting-sha-1.html
Suggest changing the default in: puppet-openssl/templates/cert.cnf.erb
to sha256
The text was updated successfully, but these errors were encountered: