-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI is not rendering the HTML description Properly #1893
Comments
Thanks for reporting! |
the descriptions are coming from the CMS
This is how it looks old version of Strorefront |
to clarify:
the descriptions are coming from the product description field in the catalog data model, not the headless CMS backing FastStore. for parity with the corresponding Store Framework component, the ProductDescription component should handle HTML text instead of assuming plaintext...whether that's the FS team's design intention or not is unclear. |
So far this field comes from the catalog as mentioned above, and is being rendered as String inside a |
Giving my 2 cents here while following-up: @hellofanny @eduardoformiga since Portal and Storeframework this is a fairly common way of utilizing product descriptions to render differently. I'm ok with this changing and finding another way to properly render if we don't create html handles, but this should be well communicated to the community, since it's an old practice =) |
Hi folks, the problem here is the fact the description renders pure HTML with your tags to avoid the content stylized? |
#2050 fixed this! |
Describe the bug
UI is not rendering the HTML description of the product properly
Steps to reproduce
Go to any PDP page
Screenshot
![Screenshot 2023-07-18 at 1 01 31 PM](https://private-user-images.githubusercontent.com/137450920/254339859-207c27de-d4a6-4b7e-98d2-f0e03660f52f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MDM4NDcsIm5iZiI6MTczOTYwMzU0NywicGF0aCI6Ii8xMzc0NTA5MjAvMjU0MzM5ODU5LTIwN2MyN2RlLWQ0YTYtNGI3ZS05OGQyLWYwZTAzNjYwZjUyZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwNzEyMjdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xMzY1OTBhNGE4MzEzM2M3YTZiNTE0MTk1OTcxODQwMjI0MDUwNDZlOGQxZTE3MjY2NTFjNzkyZmU2YjA1NWEwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.-z8P-YSLQJ_GpwvHUMNR-6LzME1wEBFmCSZjrlvPoxc)
#evergreen
"@faststore/core": "2.1.43",
The text was updated successfully, but these errors were encountered: