-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min and max value options #36
base: master
Are you sure you want to change the base?
Conversation
@codymoorhouse Number.MAX_SAFE_INTEGER
// AND
Number.MIN_SAFE_INTEGER as default values |
2b23a57
to
c9ac355
Compare
@ankurk91 Great suggestion! Didn't even realize those existed, it has been changed! |
@@ -2,6 +2,11 @@ import defaults from './options' | |||
|
|||
function format (input, opt = defaults) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codymoorhouse
Input var can be a string. If decimal is ',' then input can be like '10,000'
This will also close #41 |
Can this please be merged? |
I created a package that has slightly different behaviour while typing that can be used if anyone wants. |
@codymoorhouse I'm looking for a directive that I can use in Vuetify; I'm semi-new to Vue; can this be done w/ your package? |
@paulpv no its currently just a component, but something I can look into in the future for sure |
Anyone know the status on this? Looking for the same feature and hoping I don't have to roll my own. |
I am almost complete implementing a component specific for Vuetify: My component could be easily stripped down to work with plain ol' Vue. |
#27 has a different implementation for this same feature. One thing I miss here is the src/docs/docs.vue example. Any other thing before it can be merged? |
tracking this issue |
Added the min and max into the docs! |
i need this |
I didn't manage to get it working (used another fork), but I found a workaround. You can prevent '-' key from propagating by adding an event handler to your input element, for example like this:
|
Still need this in Feb 2020 |
any news to accept this PR? |
Any updates? |
Any progress in that? |
It would be great if PR's were accepted. 😅 |
Why didn't anyone accept this PR yet? |
This lib is abandoned, use v-currency-input instead |
Glory for Jesus this pull request were approved1 \o/ 😁 |
i have switched to this package |
Please, merge it! |
closes #24