Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min and max value options #36

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

codymoorhouse
Copy link

@codymoorhouse codymoorhouse commented Oct 31, 2017

closes #24

@ankurk91
Copy link

ankurk91 commented Dec 26, 2017

@codymoorhouse
What about having

Number.MAX_SAFE_INTEGER
// AND
Number.MIN_SAFE_INTEGER

as default values

@codymoorhouse codymoorhouse force-pushed the master branch 3 times, most recently from 2b23a57 to c9ac355 Compare January 2, 2018 16:13
@codymoorhouse
Copy link
Author

@ankurk91 Great suggestion! Didn't even realize those existed, it has been changed!

@@ -2,6 +2,11 @@ import defaults from './options'

function format (input, opt = defaults) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codymoorhouse
Input var can be a string. If decimal is ',' then input can be like '10,000'

@chosten
Copy link

chosten commented Feb 11, 2018

This will also close #41

@paulpv
Copy link

paulpv commented Apr 3, 2018

Can this please be merged?

@codymoorhouse
Copy link
Author

I created a package that has slightly different behaviour while typing that can be used if anyone wants.

Vue2 Moola

@paulpv
Copy link

paulpv commented Apr 3, 2018

@codymoorhouse I'm looking for a directive that I can use in Vuetify; I'm semi-new to Vue; can this be done w/ your package?

@codymoorhouse
Copy link
Author

@paulpv no its currently just a component, but something I can look into in the future for sure

@harpojaeger
Copy link

Anyone know the status on this? Looking for the same feature and hoping I don't have to roll my own.

@paulpv
Copy link

paulpv commented Apr 13, 2018

I am almost complete implementing a component specific for Vuetify:
https://github.com/paulpv/vuetify-number-field
I hope to publish it to npmjs today, but zero promises.

My component could be easily stripped down to work with plain ol' Vue.

@wregis
Copy link

wregis commented Sep 27, 2018

#27 has a different implementation for this same feature. One thing I miss here is the src/docs/docs.vue example.

Any other thing before it can be merged?

@lucbic
Copy link

lucbic commented Oct 29, 2018

tracking this issue

@codymoorhouse
Copy link
Author

codymoorhouse commented May 9, 2019

#27 has a different implementation for this same feature. One thing I miss here is the src/docs/docs.vue example.

Any other thing before it can be merged?

Added the min and max into the docs!

@gustavomcastro
Copy link

i need this

@loomchild
Copy link

I didn't manage to get it working (used another fork), but I found a workaround. You can prevent '-' key from propagating by adding an event handler to your input element, for example like this:

@keydown="$event.key === '-' ? $event.preventDefault() : null"

@chasedeanda
Copy link

Still need this in Feb 2020

bagaskarawg added a commit to bagaskarawg/v-money that referenced this pull request Jun 11, 2020
@CavalcanteLeo
Copy link

CavalcanteLeo commented Aug 5, 2020

any news to accept this PR?

@JuanxCursed
Copy link

Any updates?

@DanyloPrykhodko
Copy link

Any progress in that?

@rayanmarcus
Copy link

It would be great if PR's were accepted. 😅

@Lakshamana
Copy link

Why didn't anyone accept this PR yet?

@CavalcanteLeo
Copy link

CavalcanteLeo commented Oct 20, 2020

This lib is abandoned, use v-currency-input instead

https://github.com/dm4t2/vue-currency-input

docs:
https://dm4t2.github.io/vue-currency-input/guide/

@rayanmarcus
Copy link

Glory for Jesus this pull request were approved1 \o/ 😁

@ankurk91
Copy link

i have switched to this package
https://github.com/beholdr/maska

@jesselpereira
Copy link

Please, merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: add min, max support