fix(reactivity): lose activeEffectScope when effectScope(true)

[a65162]

Vue SFC Playground:

1. v3.2.30
2. v3.2.29

v3.2.30 will be lost activeEffectScope and previous version was worked properly.

[netlify]

✅ Deploy Preview for vuejs-coverage ready!

Name	Link
🔨 Latest commit	513cc8b
🔍 Latest deploy log	https://app.netlify.com/sites/vuejs-coverage/deploys/623af1adf5286f00086718ba
😎 Deploy Preview	https://deploy-preview-5575--vuejs-coverage.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for vue-next-template-explorer ready!

Name	Link
🔨 Latest commit	513cc8b
🔍 Latest deploy log	https://app.netlify.com/sites/vue-next-template-explorer/deploys/623af1ad43732c0009729728
😎 Deploy Preview	https://deploy-preview-5575--vue-next-template-explorer.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for vue-sfc-playground ready!

Name	Link
🔨 Latest commit	513cc8b
🔍 Latest deploy log	https://app.netlify.com/sites/vue-sfc-playground/deploys/623af1addb2cd900086d7d96
😎 Deploy Preview	https://deploy-preview-5575--vue-sfc-playground.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[a65162]

Does any maintainer want to review this PR?

[LinusBorg]

as you may have noticed, we have quite a backlog of PRs, so we are thankful for your patience.

[posva]

Can you add a regression test for this?

[a65162]

Can you add a regression test for this?

Sure.

[qq15725]

off() is the same problem.

[qq15725]

Maybe it would be better to just change these two positions.

  constructor(detached = false) {
    // 👇🏻 this line
    this.parent = activeEffectScope
    if (!detached && activeEffectScope) {
      this.index =
        (activeEffectScope.scopes || (activeEffectScope.scopes = [])).push(
          this
        ) - 1
    }
  }

      // nested scope, dereference from parent to avoid memory leaks
      // 👇🏻 this line
      if (this.index !== undefined && this.parent && !fromParent) {
        // optimized O(1) removal
        const last = this.parent.scopes!.pop()
        if (last && last !== this) {
          this.parent.scopes![this.index] = last
          last.index = this.index
        }
      }

[posva]

@qq15725 do you have a failing test case so we can add it?

[qq15725]

@posva

Vue SFC Playground: 3.2.31

<script setup>
  import { effectScope, onScopeDispose } from 'vue'
  effectScope(true).off()
  onScopeDispose(() => undefined)
</script>

Vue warn

[Vue warn] onScopeDispose() is called when there is no active effect scope to be associated with.

[qq15725]

test case:

it('getCurrentScope() stays valid when offed a detached nested EffectScope', () => {
  const parentScope = new EffectScope()

  parentScope.run(() => {
    const currentScope = getCurrentScope()
    expect(currentScope).toBeDefined()
    const detachedScope = new EffectScope(true)
    detachedScope.off()

    expect(getCurrentScope()).toBe(currentScope)
  })
})

[posva]

Thanks. You don't call off on an effectScope, you call stop() (https://vuejs.org/api/reactivity-advanced.html#effectscope) so that will never happen in a real scenario.