This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Fix #86, deIndent template code before preprocessing #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes pug work consistently
test/expects/pug.js
Outdated
| @@ -1,3 +1,3 @@ | |||
| var pug = { template: "<div class=\"pug__test keep-me\"><article><p>foo</p></article></div>",cssModules: {"test":"pug__test"},}; | |||
| var pug = { template: "<div class=\"pug__test keep-me\" v-if=\"true\"><article><p>foo</p></article></div><p v-else=\"v-else\">nothing</p>",cssModules: {"test":"pug__test"},}; | |||
There was a problem hiding this comment.
Does v-else correctly work here? It seems pug cannot know v-else is a boolean attribute but Vue compiler does not care. I'm not a pug user personally. Maybe @aleksejevski can give a comment.
There was a problem hiding this comment.
I think we need specify doctype option for pug compiler.
https://pugjs.org/language/doctype.html#doctype-option
There was a problem hiding this comment.
Thank you! I don't know that!
znck
approved these changes
May 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86. This should give template preprocessor more consistent code. vue-template-compiler also deindent before preprocessing.
/ping @znck