Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Vetur's Language Features with ene-to-end tests #802

Closed
20 tasks done
octref opened this issue May 22, 2018 · 2 comments
Closed
20 tasks done

Cover Vetur's Language Features with ene-to-end tests #802

octref opened this issue May 22, 2018 · 2 comments

Comments

@octref
Copy link
Member

octref commented May 22, 2018

https://github.com/octref/vscode-language-server-e2e-test

  • Infrastructure from https://github.com/octref/vscode-language-server-e2e-test
  • Basic formatting
  • Basic definition
  • Full formatting
  • Full definition
  • Completion
    • Template
    • Style
    • Script
  • Diagnostics
  • Hover
  • Highlight
  • References
  • Document Link
  • Document Symbol
  • Color Presentation — later, will need to update LanguageServer node module first
  • Signature Help — later, this is only available to <script> section and that is tightly coupled with the TS version we are using (about to update).

  • Setup travis so e2e test runs together with unit tests
  • Setup coverage report — seems too tricky with mocha + TypeScript and then our extension setup

Functionalities:

  • Reenable documentLink
@octref
Copy link
Member Author

octref commented Aug 9, 2018

@HerringtonDarkholme FYI, think these tests are much easier to write.

@ktsn I'll update the type-checking PR with E2E tests. Otherwise it's impossible to mock up everything for testing.

@HerringtonDarkholme
Copy link
Member

Sounds Great! E2E test is better for script/style integration than unit test. Thanks for bringing about e2e framework!

@octref octref mentioned this issue Aug 13, 2018
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants