Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially confusing name of test service #876

Closed
chrisvfritz opened this issue Feb 24, 2018 · 4 comments
Closed

Potentially confusing name of test service #876

chrisvfritz opened this issue Feb 24, 2018 · 4 comments

Comments

@chrisvfritz
Copy link
Contributor

The name of vue-cli-service test seems a little misleading to me, since it's only running unit tests but the test directory contains both unit and e2e tests (assuming the user has chosen to install both).

What would you think about a rename to vue-cli-service unit to highlight the association with the folder?

@dennythecoder
Copy link

I agree with the intent, but it seems like there's a trend to put a verb in that place. Perhaps unit-test? Elongating it may be problematic, but it sounds better in my head

@yyx990803 yyx990803 removed the 3.0 label Mar 1, 2018
@FlorianWendelborn
Copy link

@dennythecoder Why can't we just change it to run both on test, and run unit on test:unit / e2e on test:e2e?

@dennythecoder
Copy link

@dodekeract, I dig that more than my suggestion. 😃

@chrisvfritz
Copy link
Contributor Author

I also like that. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants