Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to pnpm #2063

Merged
merged 8 commits into from
Jan 22, 2024
Merged

chore: migrate to pnpm #2063

merged 8 commits into from
Jan 22, 2024

Conversation

Jinjiang
Copy link
Member

... and

  • fixed some typescript errors
  • improved some test cases

@Jinjiang Jinjiang marked this pull request as draft January 11, 2024 02:12
@Jinjiang Jinjiang marked this pull request as ready for review January 11, 2024 02:37
@Jinjiang Jinjiang marked this pull request as draft January 11, 2024 02:37
@Jinjiang Jinjiang marked this pull request as ready for review January 13, 2024 14:00
sxzz
sxzz reviewed Jan 19, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@haoqunjiang haoqunjiang merged commit 6986365 into main Jan 22, 2024
6 checks passed
@Jinjiang Jinjiang deleted the jinjiang/pnpm branch January 22, 2024 22:44
@Airkro
Copy link

Airkro commented Apr 25, 2024 •
edited
Loading

Using pnpm 8.x, you should add this file:

# .npmrc
enable-pre-post-scripts = true

to make sure run pretest before test.

Or using pnpm 9.x

See:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz left review comments

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jinjiang @Airkro @haoqunjiang @sxzz