-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onError not called on next false #2956
Comments
Don't hijack the issue helper. A repro is required |
As i said, just check the code, you missed onError callback calling here: https://github.com/vuejs/vue-router/blob/dev/src/history/base.js#L107 , but checking for false here: https://github.com/vuejs/vue-router/blob/dev/src/history/base.js#L153 simple code: i know, thats expected coz that's onError which mean calback should be called only on Error, but how we should operate/hook on false next on global level, which also stop routing? I think you should add ||error===false You really need repo gor this? |
https://github.com/vuejs/vue-router/blob/dev/src/history/base.js#L107
not called on return false, should be called, or add global onAbort hook.
Also npm src, doesn't contain subdirs, there only 4-5 files in root src, nothing else.
@posva
The text was updated successfully, but these errors were encountered: