You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It removes any content inside a Vue component - event if it is not a text node. This is potentially risky behavior for complex components like CKEditor where the component expects that DOM is not changed externally. More info here: ckeditor/ckeditor5#2016 (comment).
What does the proposed API look like?
After reading the original rationale behind this change (#6601 (comment)) I'm not sure if Chrome 55 is still an issue as it was 2 years before.
Ideally, this code is not needed anymore but in a case that it is still needed then maybe an additional check for node type would be better.
The text was updated successfully, but these errors were encountered:
Some specific older versions of chrome are supported, dropping the support would be a breaking change, we cannot do it.
If you have a boiled down reproduction without ckeditor of the problem, please open a new issue with it
Hi! Thanks for the clarification. Where can we find information about which versions of Chrome are supported? I guess that at some point in the future you're going to finally drop support for some really old versions, as it happens with every project from time to time. I wonder if it's possible for us to somehow track this decision so we can remove the workaround from our code once you'll clean up Vue's implementation.
What problem does this feature solve?
We've encountered a bug where Vue was removing a single DOM element from an editor component.
Namely this code:
0f2cb09
It removes any content inside a Vue component - event if it is not a text node. This is potentially risky behavior for complex components like CKEditor where the component expects that DOM is not changed externally. More info here: ckeditor/ckeditor5#2016 (comment).
What does the proposed API look like?
After reading the original rationale behind this change (#6601 (comment)) I'm not sure if Chrome 55 is still an issue as it was 2 years before.
Ideally, this code is not needed anymore but in a case that it is still needed then maybe an additional check for node type would be better.
The text was updated successfully, but these errors were encountered: