Static type="checkbox" with v-bind (fix #7811) #7819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
approved these changes
Mar 13, 2018
jkzing
reviewed
Mar 13, 2018
| @@ -34,7 +34,7 @@ function preTransformNode (el: ASTElement, options: CompilerOptions) { | |||
| if (map[':type'] || map['v-bind:type']) { | |||
| typeBinding = getBindingAttr(el, 'type') | |||
| } | |||
| if (!typeBinding && map['v-bind']) { | |||
| if (!map.type && !typeBinding && map['v-bind']) { | |||
There was a problem hiding this comment.
This would make following case lose type binding:
<input type="checkbox" v-model="test" v-bind="{type: typeBindingValue}">So maybe
typeBinding = `(${map['v-bind']}).type || '${map.type}'`EDIT: the one above is not comprehensive, while map.type still could be undefined.
typeBinding = `(${map['v-bind']}).type || ${JSON.stringify(map.type)}`
There was a problem hiding this comment.
@hirokiosame If you could add the test as well, that would be great 👌
There was a problem hiding this comment.
I don't think we should allow v-bind to override a static type, it's gonna be confusing if done accidentally and I don't think there's a valid use case.
yyx990803
pushed a commit
that referenced
this pull request
Mar 13, 2018
This was referenced Mar 14, 2018
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
aJean
pushed a commit
to aJean/vue
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: