Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work around the buggy behavior of textNode in old chrome. fix #6601 #6611

Closed
wants to merge 1 commit into from

Conversation

defcc
Copy link
Member

@defcc defcc commented Sep 15, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

fix #6601

There are currently many browsers based on the outdated chrome in China which could not got autoupdated.
This PR tries to work around the textNode wrong behavior in old version of Chrome.

As for the proper test case, I haven't added the proper test case as it's a problem of outdated browser version. Let me know if it is necessary to add it.

@yyx990803
Copy link
Member

Thanks for the PR! I found an easier fix by force removing the node before applying innerHTML/textContent in 0f2cb09

@yyx990803 yyx990803 closed this Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

textNode removed unexpectedly due to Chrome 55 bug
2 participants