Fix: add devtools to StoreOptions interface
#1478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haversnail
changed the title
devtools to store options typedevtools to StoreOptions interface
kazupon
approved these changes
Jan 30, 2019
|
/ping @ktsn |
ktsn
requested changes
Jan 31, 2019
There was a problem hiding this comment.
@haversnail Thank you for adding the property. Can we add a test code for it?
|
Coming with an outside perspective: Someone creates a type annotation for you which allows using a publicly documented option on the store with typescript. 5 months later this is still not possible. I fail to see how a test here (whatever that should look like) can trump bringing this into the project. |
|
@ktsn We still want this right? If so, I can take this over. |
ktsn
pushed a commit
that referenced
this pull request
Apr 23, 2020
Add `devtools` to store options type test: add test case for devtools type
|
Added a test case and merged in 38c11dc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
StoreOptionstype to include thedevtoolsoption, resolving TypeScript error when option is included in store constructor.