Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return object with classes on MdBadge (MdBadge do not accept color #1854 issue) #1856

Merged
merged 1 commit into from
Jul 13, 2018

Conversation

nkoik
Copy link
Contributor

@nkoik nkoik commented Jul 12, 2018

Fix bug on MdBadge according to this issue issue 1854.

md-badge class wasn't inherited to nested element in component, because in filterClasses wasn't returned the object.

<md-badge class="md-primary" md-content="1">
    <md-button class="md-icon-button">
        <md-icon>notifications</md-icon>
    </md-button>
</md-badge>

@VdustR VdustR merged commit 87cf617 into vuematerial:dev Jul 13, 2018
marcosmoura added a commit that referenced this pull request May 11, 2019
* origin: (55 commits)
  fix(MdSvgLoader): svg loader for invalid / missing mimetype (#1942)
  docs(Icon): fix minor typo (#1973)
  fix(MdRouterLink): new router-link registration name (#1978)
  chore: apply discord vanity URL (#1927)
  docs(ROADMAP.md): replace dead slack invite link with discord invite link (#1924)
  docs(Table): fix grammar issues (#1902)
  feat: router link components improvements (#1651)
  fix(MdTable): recalculate fixed header width on data changes (#1877)
  fix(MdDialogContent): missing theme class (#1876)
  docs(Elevation and Layout): Typos fixed and improved documentation. (#1878)
  fix(MdTable): nextTick selection data (#1874)
  docs(BottomBar): fix typo (#1875)
  docs(MdButton): escape a tag (#1872)
  docs(Input): typos and correction
  chore: upgrade dependencies
  fix(MdField): remove firefox required box-shadow
  feat: disable complexity rules for some methods
  fix(MdProgressSpinner): fix CSP error (#1850)
  fix: MdBadge do not accept color #1854 issue (#1856)
  fix: fix the repeated generated css theme classes if there is multiple themes defined (#1784)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants