Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VPagination): visible items for selection in middle #20322

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

J-Sek
Copy link
Contributor

@J-Sek J-Sek commented Aug 13, 2024

Description

Shows one more element when selection is in the middle and we display "..." twice.

image

resolves #18853

Markup:

<template>
  <v-app>
    <v-container class="d-flex flex-column justify-center ga-3">
      <v-card>
        <VPagination length="100" total-visible="5" />
      </v-card>
      <v-card>
        <pre class="text-center">Repro for #14396 that guided most recent changes to this logic</pre>
        <v-pagination v-model="page" total-visible="3" length="3" />
        <v-pagination v-model="page" total-visible="3" length="4" />
        <v-pagination v-model="page" total-visible="4" length="3" />
        <v-pagination v-model="page" total-visible="4" length="4" />
      </v-card>
    </v-container>
  </v-app>
</template>

<script setup lang="ts">
import { ref } from "vue";
const page = ref(1)
</script>

@KaelWD KaelWD force-pushed the master branch 2 times, most recently from e20cfec to 2766105 Compare August 15, 2024 09:17
@KaelWD KaelWD force-pushed the master branch 3 times, most recently from 4c970f9 to 6a3285f Compare September 3, 2024 18:11
@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VPagination labels Oct 28, 2024
@J-Sek J-Sek requested a review from MajesticPotatoe January 23, 2025 10:35
@johnleider johnleider added this to the v3.7.x milestone Jan 27, 2025
@johnleider johnleider changed the title fix(VPagination): correct visible items for selection in the middle fix(VPagination): visible items for selection in middle Jan 27, 2025
@johnleider johnleider merged commit 36c4d46 into vuetifyjs:master Jan 27, 2025
10 checks passed
@J-Sek J-Sek deleted the fix-18853 branch January 27, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VPagination T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.4.6] VPagination with total-visible="4" shows ... instead of numbers
3 participants