Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed and to be deleted #20660

Closed
giuliohome opened this issue Nov 2, 2024 · 5 comments · May be fixed by #20742
Closed

Closed and to be deleted #20660

giuliohome opened this issue Nov 2, 2024 · 5 comments · May be fixed by #20742
Labels
C: VAutocomplete VAutocomplete C: VCombobox VCombobox good first issue A quick-win fix that would be great for new contributors S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected

Comments

@giuliohome
Copy link

giuliohome commented Nov 2, 2024

Delete, please ignore or reopen you yourselves. I have unsubscribed from this thread

@MatthewAry MatthewAry added T: bug Functionality that does not work as intended/expected C: VCombobox VCombobox good first issue A quick-win fix that would be great for new contributors and removed S: triage labels Nov 14, 2024
@MatthewAry
Copy link
Contributor

May be related to #17122

@yuwu9145
Copy link
Member

I think the previous conclusion of whether empty string is really empty is:

  • For select components, empty string is legit, null & undefined are real empty
  • For text field, empty string, null & undefined are all real empty

So in my opinion, the behaviour is expected, the real confusion is it's missing in docs and it's not clear to users ##18737 (comment)

@giuliohome
Copy link
Author

Just to know so that I can tell my point of view to my colleagues in my company, have you considered what I have noted here?

This contradicts the logic in onUpdateModelValue which correctly resets the model.value to [] also when v === ''.

Thank you

@giuliohome
Copy link
Author

giuliohome commented Nov 29, 2024

I have already deleted my fork of vuetify, I'm going to unsubscribe from this thread, I have no time to waste, sorry, bye

@giuliohome giuliohome changed the title [Bug Report][3.7.3] v-combobox placeholder is not consistent with v-textbox Closed and to be deleted Nov 29, 2024
@J-Sek
Copy link
Contributor

J-Sek commented Nov 29, 2024

  • For text field, empty string, null & undefined are all real empty

VCombobox is really just a text field with suggestions, so it would make sense to make it recognize empty string as no value. But also, opinions aside, unless empty string is a value in one of the items - null, undefined, '' there is no visual difference from end-user perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VAutocomplete VAutocomplete C: VCombobox VCombobox good first issue A quick-win fix that would be great for new contributors S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
4 participants