Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VField): hide label with single-line #20773

Merged

Conversation

SonTT19
Copy link
Contributor

@SonTT19 SonTT19 commented Dec 10, 2024

Description

fixes #20751
fixes #20772

Markup:

<template>
  <v-app>
    <v-container>
      <v-text-field />
      <v-text-field :label="msg" />
      <v-text-field :label="msg" single-line />
    </v-container>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'

  const msg = ref('Hello World!')
</script>

@ranjith19
Copy link

This needs to be merged if correct - we had to lock the version to 3.7.4 due to the regression.

@xqqp
Copy link

xqqp commented Jan 22, 2025

Looking forward to this PR getting merged. The CI failures don't seem related to this change.

@johnleider johnleider added this to the v3.7.x milestone Jan 24, 2025
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VField labels Jan 24, 2025
@johnleider johnleider changed the title fix(VField): fix regression hide label with single-line fix(VField): hide label with single-line Jan 24, 2025
@johnleider johnleider merged commit 3ef363a into master Jan 24, 2025
15 of 17 checks passed
@johnleider johnleider deleted the fix/20751-v-field-regression-hide-label-single-line branch January 24, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VField T: bug Functionality that does not work as intended/expected
Projects
None yet
4 participants