Smoke test dependents #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| t.plan(2) | ||
|
|
||
| // Clone fully because we need git history for remark-git-contributors | ||
| gitPullOrClone(url, cwd, { depth: Infinity }, (err) => { |
| const stdio = ['ignore', process.stderr, process.stderr, 'ipc'] | ||
| const cli = path.join(__dirname, 'cli.js') | ||
|
|
||
| cp.fork(cli, { cwd, stdio }).on('exit', function (code) { |
There was a problem hiding this comment.
Any special reason for .fork than using .spawn? Just curious.
There was a problem hiding this comment.
I only chose it because it has a simpler API if it's JS you want to execute. Doesn't really matter.
ralphtheninja
approved these changes
Aug 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to judge remark dependency updates (like the 4 PRs we have open now), which frequently have "to be safe" major bumps that don't actually affect us.