From ad386a01665b59fba3c808691ef29ab88132db19 Mon Sep 17 00:00:00 2001
From: Erika Miguel <erika@bocoup.com>
Date: Thu, 16 May 2024 13:39:51 -0400
Subject: [PATCH 1/3] Use aria-checked for AssignTesterDropdown

---
 .../components/TestQueue/AssignTesterDropdown/index.jsx   | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/client/components/TestQueue/AssignTesterDropdown/index.jsx b/client/components/TestQueue/AssignTesterDropdown/index.jsx
index 98463d388..ee9efab8e 100644
--- a/client/components/TestQueue/AssignTesterDropdown/index.jsx
+++ b/client/components/TestQueue/AssignTesterDropdown/index.jsx
@@ -149,6 +149,9 @@ const AssignTesterDropdown = ({
                                     variant="secondary"
                                     as="button"
                                     key={`tpr-${testPlanReportId}-assign-tester-${username}`}
+                                    aria-checked={
+                                        testerIsAssigned ? true : false
+                                    }
                                     onClick={async () => {
                                         const updatedIsAssigned =
                                             !testerIsAssigned;
@@ -165,11 +168,6 @@ const AssignTesterDropdown = ({
                                     }}
                                 >
                                     {icon && <FontAwesomeIcon icon={icon} />}
-                                    <span className="sr-only">{`${username} ${
-                                        testerIsAssigned
-                                            ? 'checked'
-                                            : 'unchecked'
-                                    }`}</span>
                                     <span
                                         aria-hidden="true"
                                         className={classname}

From 3ee1d3df7e591ba39ffb2127b7cacddeacc2c168 Mon Sep 17 00:00:00 2001
From: Erika Miguel <erika@bocoup.com>
Date: Thu, 16 May 2024 14:14:20 -0400
Subject: [PATCH 2/3] Fix tests

---
 client/tests/AssignTesterDropdown.test.jsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/client/tests/AssignTesterDropdown.test.jsx b/client/tests/AssignTesterDropdown.test.jsx
index bb8dce235..032b98235 100644
--- a/client/tests/AssignTesterDropdown.test.jsx
+++ b/client/tests/AssignTesterDropdown.test.jsx
@@ -179,7 +179,7 @@ describe('AssignTesterDropdown', () => {
         fireEvent.click(button);
 
         const items = await screen.findAllByText(/bee/);
-        expect(items.length).toBe(2); // One for display, one for sr-only
+        expect(items.length).toBe(1);
         fireEvent.click(items[0]);
 
         await waitFor(async () => {
@@ -205,7 +205,7 @@ describe('AssignTesterDropdown', () => {
         fireEvent.click(button);
 
         const items = await screen.findAllByText(/NVDA Bot/);
-        expect(items.length).toBe(2); // One for display, one for sr-only
+        expect(items.length).toBe(1);
         fireEvent.click(items[0]);
 
         await waitFor(() => {

From be8cb2b6798f8fff4239b1d88459cde874382c99 Mon Sep 17 00:00:00 2001
From: Erika Miguel <erika@bocoup.com>
Date: Mon, 20 May 2024 16:09:08 -0400
Subject: [PATCH 3/3] Update dropdown item role to menuitemcheckbox and remove
 aria-hidden from username

---
 client/components/TestQueue/AssignTesterDropdown/index.jsx | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/client/components/TestQueue/AssignTesterDropdown/index.jsx b/client/components/TestQueue/AssignTesterDropdown/index.jsx
index ee9efab8e..a99537354 100644
--- a/client/components/TestQueue/AssignTesterDropdown/index.jsx
+++ b/client/components/TestQueue/AssignTesterDropdown/index.jsx
@@ -145,7 +145,7 @@ const AssignTesterDropdown = ({
                             }
                             return (
                                 <Dropdown.Item
-                                    role="menuitem"
+                                    role="menuitemcheckbox"
                                     variant="secondary"
                                     as="button"
                                     key={`tpr-${testPlanReportId}-assign-tester-${username}`}
@@ -168,10 +168,7 @@ const AssignTesterDropdown = ({
                                     }}
                                 >
                                     {icon && <FontAwesomeIcon icon={icon} />}
-                                    <span
-                                        aria-hidden="true"
-                                        className={classname}
-                                    >
+                                    <span className={classname}>
                                         {`${tester.username}`}
                                     </span>
                                 </Dropdown.Item>