Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim ids when cloning descriptions #76

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Trim ids when cloning descriptions #76

merged 2 commits into from
Nov 19, 2021

Conversation

saschanaz
Copy link
Member

ReSpec assigns ids to reference nodes, and cloning them causes id collision issue as seen in w3c/aria#1623 (comment). This workarounds the issue.

@saschanaz saschanaz mentioned this pull request Oct 30, 2021
Closed
@saschanaz
Copy link
Member Author

saschanaz commented Nov 18, 2021 •
edited
Loading

@jnurthen Per #61, should the file be moved to w3c/aria and should the fix happen there instead?

@jnurthen
Copy link
Member

@saschanaz No - not until we progress that issue. aria-common ins the right place for now.

@jnurthen jnurthen merged commit 5863d21 into w3c:main Nov 19, 2021
@jnurthen
Copy link
Member

Thanks

@saschanaz saschanaz deleted the clonewithoutids branch November 19, 2021 00:27
@saschanaz saschanaz mentioned this pull request Nov 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saschanaz @jnurthen