From 9a5e55ccbeb0f1bf92b6127c9865da8426d1c864 Mon Sep 17 00:00:00 2001
From: Matt King <a11yThinker@Gmail.com>
Date: Tue, 24 Oct 2023 16:17:48 -0700
Subject: [PATCH] Landmark Practice: Add note to prevent dialog content wrapped
 in a landmark (pull #2818)

Resolve issue #2512 by adding the following note to principles of landmark design:

>Note that wrapping the content of a modal dialog in a landmark region is unnecessary. A landmark that wraps modal content cannot provide any benefit to users because it is not perceivable unless the modal is open. In addition, when a modal is open, a landmark containing its content is superfluous because the modal itself is a container that provides both a name and boundaries.
---
 .../patterns/landmarks/examples/general-principles.html    | 5 +++++
 .../landmark-regions/landmark-regions-practice.html        | 7 +++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/content/patterns/landmarks/examples/general-principles.html b/content/patterns/landmarks/examples/general-principles.html
index c6cccd8124..52ccf36fbb 100644
--- a/content/patterns/landmarks/examples/general-principles.html
+++ b/content/patterns/landmarks/examples/general-principles.html
@@ -80,6 +80,11 @@ <h1>General Principles</h1>
               <li>
                 Landmark roles can be nested to identify parent/child relationships of the information being presented.
               </li>
+              <li>
+                Note that wrapping  the content  of a modal dialog in a landmark region is unnecessary.
+                A landmark that wraps modal content cannot provide any benefit to users because it is not perceivable unless the modal is open.
+                In addition, when a modal is open, a landmark containing its content is   superfluous because the modal itself is a container that provides both a name and boundaries.
+              </li>
             </ul>
 
             <p style="font-weight: bold">Step 3: Label each area</p>
diff --git a/content/practices/landmark-regions/landmark-regions-practice.html b/content/practices/landmark-regions/landmark-regions-practice.html
index 35420c5619..87ee9d44ff 100644
--- a/content/practices/landmark-regions/landmark-regions-practice.html
+++ b/content/practices/landmark-regions/landmark-regions-practice.html
@@ -103,10 +103,13 @@ <h2>General Principles of Landmark Design</h2>
 
         <ul>
           <li>Assign landmark roles based on the type of content in the area.</li>
-
           <li><code>banner</code>, <code>main</code>, <code>complementary</code> and <code>contentinfo</code> landmarks should be top level landmarks.</li>
-
           <li>Landmark roles can be nested to identify parent/child relationships of the information being presented.</li>
+          <li>
+            Note that wrapping  the content  of a modal dialog in a landmark region is unnecessary.
+            A landmark that wraps modal content cannot provide any benefit to users because it is not perceivable unless the modal is open.
+            In addition, when a modal is open, a landmark containing its content is superfluous because the modal itself is a container that provides both a name and boundaries.
+          </li>
         </ul>
 
         <p id="aria_lh_step3"><strong>Step 3: Label areas</strong></p>