-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disclosure FAQ: Should the answers be landmark regions? #1002
Comments
DL, DD and DT seems like the right structure to me. The role is not being overridden in this example so can you explain the rationale to change it? |
@jnurthen just checking if it should be, as you point out the semantics are not being overridden, so in the old printing proof reading term STET :-) Leave it as it is. |
In relation to this What is the difference between this Example Disclosure (Show/Hide) Example on this page and Accordion Example I don't quite get why one can have simple aria-expanded and aria-controls only while the accordion also includes role region and a different structure. Both essentially do the same thing. I suggest a role of region is needed on the ‘disclosure (show/hide) as well for consistency. |
I'm in favor of adding role=region plus aria-labelledby to map back to the triggering element, especially to handle cases where show/hide controls like these are nested. |
Related to #954 |
@accdc please add/record your suggestion based on the discussion at APG meeting on Oct. 26. Thanks in advance. |
Hi, |
Due to the DL, DT DD structure being changed to a DIV structure I believe the example for disclosure widgets should also be updated. Happy to do this if approved.
Example Disclosure (Show/Hide) for Answers to Frequently Asked Questions
https://www.w3.org/TR/wai-aria-practices/examples/disclosure/disclosure-faq.html
Related to:
Accordion Example: Restructure to remove
dl
element #815#815The text was updated successfully, but these errors were encountered: