Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page up/down on day and month for spin button is underspecified and has bug #1426

Closed
spectranaut opened this issue Jun 15, 2020 · 1 comment

Comments

@spectranaut
Copy link
Contributor

To reproduce:

  • Go to the date picker spin button example
  • Focus on the day spinner
  • Change the spinner to have the value of the last day of the month
  • Press "page up"
  • BUG: Notice that the day becomes the first of the month, not the 4th day of the month

If you change the date spinner to be the first of the month, and send "page down", you get a value that is 4 days before the end of the month. So you can see, page up and page down act differently at the boundaries, and the correct behavior is not explained in the Keyboard Support table.

I think we should always see a 5 unit increase and decrease, rather than turning it into the first or last day available!

Page up and page down for month has the same buggy behavior.

@nschonni
Copy link
Contributor

nschonni commented Dec 1, 2020

Was playing around with the tests today to see if I could fix it. One thing I was trying was to use END/HOME at the start of the test to get consistent results, but then I ran into the PAGEUP/PAGEDOWN issue where wrapping around the year seems off. EX:

  • December + PAGEDOWN = July
  • July + PAGEDOWN = February
  • February + PAGEDOWN = December

Not sure if the expected behaviour is to still go -5 over the date boundry or if the current "Max Month" is correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants