Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs examples do not correctly place focus after deleting a tab #286

Closed
mcking65 opened this issue Feb 14, 2017 · 1 comment
Closed

Tabs examples do not correctly place focus after deleting a tab #286

mcking65 opened this issue Feb 14, 2017 · 1 comment
Assignees
@ZoeBijl
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Milestone
1.1 APG Release 1

Comments

@mcking65
Copy link
Contributor

mcking65 commented Feb 14, 2017 •
edited
Loading

In the
Example of Tabs With Automatic Activation and the
Example of Tabs With Manual Activation,
after the "Joke" tab is deleted, focus is placed on the first tab. It should be placed on the tab just before the one that was deleted.
This was referenced Feb 14, 2017
Closed
Closed
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Feb 14, 2017
@mcking65 mcking65 added this to the 1.1 PR milestone Feb 14, 2017
@ZoeBijl
Copy link
Contributor

ZoeBijl commented Feb 15, 2017

This is fixed in 47b9529.

It now sets focus to the tab directly before the deleted one. Unless the first tab is deleted, then it’ll set focus to the tab that is now the first one.

@ZoeBijl ZoeBijl closed this as completed Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZoeBijl ZoeBijl

Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Projects
Tabs Pattern and Examples Development Project
Status: Complete
Milestone
1.1 APG Release 1
Development

No branches or pull requests
2 participants
@ZoeBijl @mcking65