Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation links for site navigation using menu buttons #1499

Closed
wants to merge 3 commits into from

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Aug 19, 2020

Initial implementation of a set of navigational links using menu-buttons.

Preview Link

@jongund jongund changed the title initial files for menu button navigation Navigation links for site navigation using menu buttons Aug 19, 2020
@mcking65
Copy link
Contributor

@jongund

I'm not really following this idea. Is this in response to a specific issue?

If we were going to offer a menubutton alternative, shouldn't we simply enhance the current menu button example so that it is a "Mythical University Pages" menubutton that opens a menu with items for about, Admissions, and Academics?

A group of menu buttons seems like it is just a menubar without the advantages of menubar, e.g., no type ahead. It is like the disclosure pattern without the advantages of the disclosure pattern, e.g., disclosure provides simple lists of actual links. To me, it feels like the worse features of both.

Perhaps we should not offer a menu button version of the mythical university nav because if you were going to have a single point of entry for a nav system, e.g., to accommodate small screens, you would likely just go all in on disclosure because of the mobile device compatibility it would offer and the fact that keyboard interaction on small screens is uncommon. The menubar approach really is desktop centric. The disclosure approach is universal.

@jongund
Copy link
Contributor Author

jongund commented Aug 22, 2020

@mcking65
This is a very common pattern used in practice. We should have it as one of the alternatives for creating navigation and discuss its advantages and disadvantages with other commonly used patterns for navigation.

@mcking65
Copy link
Contributor

@jongund

I've never seen a group of ARIA menu buttons used this way. Is it the ARIA implementation that is very common or some other aspect of this example?

Regardless, I thought we agreed to first align all the nav-like examples that we already have before building more. To that end, in our last discussion of this topic, I promised to write a list of incremental changes for resolving #89 for the group to review on Sep 1. I think we should discuss as a group before creating more examples related to site nav.

@jongund
Copy link
Contributor Author

jongund commented Oct 25, 2020

no interest in including as an example right now

@jongund jongund closed this Oct 25, 2020
@jongund jongund deleted the menu-button-nav branch February 9, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants