Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessible Name Guidance by Role Section: Change marquee name from required to discretionary #1572

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

smhigley
Copy link
Contributor

@smhigley smhigley commented Oct 15, 2020

Related to w3c/aria#1339 and w3c/aria#1342 on the ARIA repo.

I chose "discretionary" to match the guidance for log.


Preview | Diff

@@ -4586,7 +4586,7 @@ <h4><span id="naming_role_guidance_heading">Accessible Name Guidance by Role</sp
</tr>
<tr>
<td><a href="#marquee" class="role-reference"><code>marquee</code></a></td>
<td>Required</td>
<td>Discretionary</td>
<td>Use <code>aria-labelledby</code> if a visible label is present, otherwise use <code>aria-label</code>.</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok but we could consider changing this to match the other discretionary roles which describe why you might want to give it an accessible name. However - I'm not sure I can really come up with a valid use case for that.

Copy link
Contributor

@carmacleod carmacleod Oct 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's valid to give a marquee a name, just didn't make sense to require it.

I very quickly tested 4 marquees using jaws/nvda in chrome/ff.

Notes:

  • The first 2 marquees use (obsolete) HTML <marquee> elements. One has aria-labelledby and the other has aria-label.
  • The next 2 are fake marquees that use a span (I didn't add any animation). As above, one has aria-labelledby and the other has aria-label.
  • Both browsers expose the role correctly, but I had to use role="marquee" ("belts and braces" style) on the 2 HTML <marquee> elements (otherwise, they just had a generic text container role).
  • Both browsers expose all 4 accessible names correctly, and they also expose the aria-live="off".
  • Both screen readers read the aria-labelledby span, because it's visible text content. :)
  • Neither screen reader read the aria-label.
  • Both screen readers read all of the marquee's content, i.e. they ignored the animated scrolling.

So we could say something along the lines of, "When naming a marquee, aria-labelledby with a visible label is recommended, because some screen readers do not read an aria-label on a marquee."

I'll try Safari/VO tomorrow.

Edit: Safari/VO reads all 4 marquees well (using VO+arrows), and even reads the name of the 2 aria-label marquees. The explicit role was also needed on the obsolete html marquee elements (same as Chrome/FF).

Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @smhigley !
Ok to go in as-is, but consider adding more specific info in the guidance column.

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @smhigley!

@mcking65 mcking65 changed the title Change marquee name from required to discretionary Accessible Name Guidance by Role Section: Change marquee name from required to discretionary Oct 23, 2020
@mcking65 mcking65 merged commit 19c745a into master Oct 23, 2020
@mcking65 mcking65 added documentation Practice Page Related to a page within the practices section of the APG labels Oct 23, 2020
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Oct 23, 2020
@mcking65 mcking65 deleted the marquee-name branch October 23, 2020 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Practice Page Related to a page within the practices section of the APG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants