Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated multithumb slider to use SVG and support mobile devices #1704

Closed
wants to merge 5 commits into from
Closed

updated multithumb slider to use SVG and support mobile devices #1704

wants to merge 5 commits into from

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Dec 23, 2020 •
edited by charmarkk
Loading

Updated multi-thumb slider example:

  1. Using SVG for the slider controls to support high contrast
  2. Added accessibility feature section
  3. Additional mobile version using input[type=number] elements to set range
  4. Updated code use the APG coding practices

Preview multi-thumb slider
Preview multi-thumb slider with mobile support

Review checklist

@jongund
Copy link
Contributor Author

jongund commented Dec 23, 2020

@mcking65 @spectranaut @nschonni
Here is the new branch and PR for the update to the multi-thumb slider examples. Seems to be passing the tests in Travis now.

@jongund jongund requested a review from mcking65 December 23, 2020 15:29
@jongund jongund requested a review from carmacleod January 10, 2021 14:51
charmarkk
charmarkk approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@charmarkk charmarkk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disregard - mistakenly chose approve

charmarkk
charmarkk requested changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@charmarkk charmarkk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Windows 10, NVDA 2020.3, JAWS 2020.2012.13; Firefox 84.0.1 and Chrome 87.0.4280.141. All worked as expected as far as documented accessibility functionality, keyboard interaction, and screen readers were concerned.

High contrast was mostly good, but the label on the thumb itself did not show up with HCM Black and Firefox. @carmacleod, could I tag you in for MacOS a11y tests? My test Mac is with another co-worker at the moment. Edit to add: See #1706 - HCM issue found appears to be a Firefox bug.

@charmarkk charmarkk mentioned this pull request Jan 11, 2021
Closed
6 tasks
@jongund
Copy link
Contributor Author

jongund commented Feb 9, 2021

This example has been updated in Pull #1758

@jongund jongund closed this Feb 9, 2021
@zcorpan zcorpan deleted the update-multithumb-slider branch May 31, 2021 12:28
@zcorpan zcorpan mentioned this pull request May 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charmarkk charmarkk charmarkk requested changes

@mcking65 mcking65 Awaiting requested review from mcking65

@spectranaut spectranaut Awaiting requested review from spectranaut

@carmacleod carmacleod Awaiting requested review from carmacleod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jongund @charmarkk