Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Include full link in message when external link errors in link-checker script #3114

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Sep 16, 2024

Modifies the error message to detail the actual link that has failed to easily relay the information instead of just providing the line and column number.

Example:
Found broken external link on content/patterns/accordion/examples/accordion.html:22:13, status was 404 would now be Found broken external link on content/patterns/accordion/examples/accordion.html:22:13. Link is https://github.com/w3c/aria-practices/projects/8, status is 404


WAI Preview Link (Last built on Sun, 03 Nov 2024 03:54:35 GMT).

@howard-e howard-e added the Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation label Sep 16, 2024
Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This small change would make determining the failing links much easier.

@mcking65 mcking65 merged commit 3c8b715 into main Nov 3, 2024
15 checks passed
@mcking65 mcking65 deleted the update-link-checker-message branch November 3, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants