Add Treegrid Example #762
Add Treegrid Example #762
Conversation
1. Modified aria-practices:
* Add placeholder section for treegrid design pattern.
* Add link to treegrid example page.
2. Add new template file: examples/treegrid/css/treegrid.css
3. Add nnew template file: examples/treegrid/js/treegrid.js
4. Add new template file: examples/treegrid/treegrid-1.html
…grid/treegrid-row-nav-primary-1.html
…toggle expansion)
For issue #132, this commit includes: * Initial implementation of an example treegrid with primarily tree-like behaviors. * Partial draft of example page content explaining the implementation.
… different ?cell param
* Enter on first cell to toggle expansion was not working * Expando button not showing in ?cell=force mode
More positive email thread about treegrids
Rename from convoluted name to treegrid-1
examples/treegrid/treegrid-1.html
Outdated
| </colgroup> | ||
| <thead> | ||
| <tr> | ||
| <th role="columnheader">Subject</th> |
There was a problem hiding this comment.
@aleventhal, @jongund, why is role columnheader added here. This is not necessary and not recommended to duplicate native semantics. Can we safely remove without breaking any selectors or js?
There was a problem hiding this comment.
Actually, a th can be a columnheader or a rowheader. I don't think it's redundant to specify. This way the browser does not need to fall back on heuristics (which different browsers may disagree about).
There was a problem hiding this comment.
Actually we can probably use scope="col".
examples/treegrid/treegrid-1.html
Outdated
| <thead> | ||
| <tr> | ||
| <th role="columnheader">Subject</th> | ||
| <th role="columnheader">Summary</th> |
There was a problem hiding this comment.
@aleventhal, @jongund, why is role row added here and on subsequent tr elements? This is not necessary and not recommended to duplicate native semantics. Can we safely remove without breaking any selectors or js?
There was a problem hiding this comment.
Good question. I would guess that it makes no difference and can be removed, but I think it should be tested with at least one screen reader to be completely sure.
FWIW, I find it easier to understand the examples when the roles are explicitly stated. When we remove "row" from the markup, should we also make sure it's clear in the docs that can be replaced with something like
This reverts commit 3b79fd4. Restoring the gridcell role declarations after rviewing the ARIA in HTML spec.
|
OK ... Editorially in reasonable shape and the only errors left are the posinset and setsize errors, which are being addressed by w3c/aria#558. So, merging to master. |
For issue #132, adds an example of the treegrid pattern.
For issue #132, merging review-ready version of treegrid example developed by @aleventhal and edited to fit example template by @jongund.
Preview | Diff