Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The factors than make an element Contentful or not-Contentful should be defined #112

Open
andydavies opened this issue Apr 6, 2023 · 1 comment
Assignees

Comments

@andydavies
Copy link

The spec states that

This document defines an API that enables monitoring the largest paint an element triggered on screen.

But Chromium doesn't follow this definition and for example excludes full viewport images (https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/speed/metrics_changelog/2020_11_lcp.md)

So both consumers and implementers of the spec have clarity and consistency on what is actually, then what is considered contentful and any exclusions should be defined

@andydavies andydavies changed the title What factors make an element Contentful or not-contentful should be defined The factors than make an element Contentful or not-Contentful should be defined Apr 20, 2023
@clelland
Copy link
Collaborator

This could be an umbrella issue for #26, #28, #70, #72, #79, and #107.

There are a number of reasons that a paint would not be considered 'contentful' for LCP purposes, and we should define those in the spec. I'll take a pass at a PR or 6 which makes them more explicit.

@clelland clelland self-assigned this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants