Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class="note" inserts incorrect heading level #155

Closed
mcking65 opened this issue Jul 31, 2022 · 2 comments
Closed

class="note" inserts incorrect heading level #155

mcking65 opened this issue Jul 31, 2022 · 2 comments
Assignees
Labels
bug Something isn't working Infrastructure

Comments

@mcking65
Copy link
Contributor

In our css, we have a class note. This class adds a heading with content "Note".

The heading level of the Note heading is incorrect. It should be 1 level deeper than the level of the section that contains it. We are consistent with the use of sections.

For example, on the combobox pattern page, there are notes with heading level 5 that should have heading level 3 because the heading of the section that contains them is level 2.

@mcking65
Copy link
Contributor Author

Even though I have raised this in the site build repo, I am wondering if this shouldn't be addressed in the content repo. That is where we apply the CSS and so the it needs to be there too. It should probably work as desired even when viewing the raw content.

@mcking65
Copy link
Contributor Author

Fixed by changes made in w3c/aria-practices#2417.
The note class no longer triggers insert of a heading; the heading is provided by the content author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants