Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs triggered by aria-practices falling out of sync #219

Closed
howard-e opened this issue Apr 27, 2023 · 1 comment
Closed

PRs triggered by aria-practices falling out of sync #219

howard-e opened this issue Apr 27, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@howard-e
Copy link
Contributor

howard-e commented Apr 27, 2023

This was recently observed in w3c/aria-practices#2622 (comment), where the following error was being surfaced:

Error:

/home/runner/work/wai-aria-practices/wai-aria-practices/scripts/pre-build/library/determineContentType.js:48
throw new Error(
^
Error: Could not determine content type for file at /home/runner/work/wai-aria-practices/wai-aria-practices/_external/aria-practices/content/about/introduction/introduction.html
This file may not follow established conventions.

The pr-create.yml seems to be missing a crucial step in ensuring the generated PR in this repository is rebased onto the default branch before regenerating the preview.

This hasn't been an issue in the past mainly because of the typically static and unrelated nature of the content and utilities. Also of assistance, was how GitHub's default updating of an existing PR works when the default branch is updated. But in this instance (and others), wai-aria-practices has undergone many changes which were not properly accounted for.

Exploring automatic rebases when the script runs (or exploring manual but assisted triggers such as actions/automatic-rebase) should be considered.

@howard-e
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In production / Completed
Development

No branches or pull requests

1 participant