-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide extraneous "Skip to main" link #26
Comments
For consistency, would be better to use the parent one.
Happy to have improvements to parent! If that needs to wait for future, OK. |
@shawna-slh wrote:
Shawn, the parent one is less functional than the one we have already made available on all example pages in TR today. So, if we use the parent one, the APG examples in the WAI site would end up being both inconsistent with the current APG and less functional than the current APG. The task force has discussed this and would like to move forward with the APG skipto functionality to ensure consistency with the current APG.
For the time being, this can be a high priority backlog issue. @richnoah do we already have an issue to track upgrading the template skipto functionality? Note that this is separate from making skipto persistently visible; that is a longer term design issue. |
#40 is about making skipto persistently visible. There should be a separate issue raised against the WAI template that upgrades it from a "skip to main" link with only one target to a more functional skip menu that can be accessed with alt+0 from any location on the page. @shawna-slh do we raise such issues in |
Yesterday, this was resolved in #62. However, now, instead of the APG skipto menu, we have only the static skip to content link. So, there is only one, but unfortunately it is the wrong one. |
I have reviewed the preview of #62, and this issue is addressed. |
Verified still fixed after today's changes to #62. |
We currently have 2 "Skip to main" links. One is from APG, the other is injected from the Supplemental Resource parent template.
We should hide the one from the parent template so that only one "Skip to main" link is present.
(In a future issue, we will mitigate the root issue by working to improve the parent "Skip to main" link from the parent template.)
The text was updated successfully, but these errors were encountered: