Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example pages and Index page: remove extraneous broken link and navigation region from end of main content #53

Closed
mcking65 opened this issue May 4, 2022 · 1 comment

Comments

@mcking65
Copy link
Contributor

mcking65 commented May 4, 2022

On the index page, and on all example pages,
there is a nav element at the end of the main content containing a single link
named "WAI-ARIA Authoring Practices 1.2".

The link is broken, and because it is in a nav element, it is prominent for screen reader users. We need to remove the nav element and link. I think we should do this before launch.

The question is whether to filter it out during build or remove it from the roughly 60 pages that contain it in the aria-practices source repo. Eventually we definitely need to remove it from the source. Should we bite the bullet and do that now? Or add some filtering code to the build?

@mcking65 mcking65 changed the title Index page: remove extraneous footer navigation region Example pages and Index page: remove extraneous broken link and navigation region from end of main content May 11, 2022
@mcking65
Copy link
Contributor Author

Verified fixed in #62 preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant