Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assets and image location and references [Required for launch] #74

Closed
SteveALee opened this issue May 11, 2022 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@SteveALee
Copy link
Contributor

SteveALee commented May 11, 2022

CC @shawna-slh

All static assets must be updated due to the limitations of Jekyll and the requirements to link to them in the integrated wai-website repo for publication.

What you need to do is:

  • move assets to {projectroot}/content-assets/wai-aria-practices/ - eg see ACT rules assets
  • Edit all assets references to be of the form `{{ @@@="/content-assets/wai-aria-practices/styles.css"}}

Likewise for the SVG files in 'content/assets' use {projectroot}/content-images/wai-aria-practices/ - you should rename the incorrect {projectroot}/content-images/wai-website-theme/

@SteveALee SteveALee added the bug Something isn't working label May 11, 2022
@SteveALee
Copy link
Contributor Author

Oh I now see PR #9 which covers part of this.

@mcking65 mcking65 changed the title [Required for launch] Fix assets and image location and references Fix assets and image location and references [Required for launch] May 11, 2022
@SteveALee
Copy link
Contributor Author

SteveALee commented May 12, 2022

Please move all images in /content-assets/wai-aria-practices to /content-images/wai-aria-practices

I know this is a bit messy but it's the convention we have for now.

If @shawna-slh agrees I propose leaving this to after the launch as it is mostly about source code structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants