Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files in /index [Required for Launch] #76

Closed
SteveALee opened this issue May 11, 2022 · 3 comments
Closed

Files in /index [Required for Launch] #76

SteveALee opened this issue May 11, 2022 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@SteveALee
Copy link
Contributor

SteveALee commented May 11, 2022

This is more a question than something that necessarily needs to be fixed.

Is there a reason the files under /index are not in /content/index? /content is the correct location for all files that are processed by Jeckyll and end up as pages. Unless they are a collection.

But I see you have a mixture of Jekyll processed SSG source files and statically served files. As these are relative URIs I think it should be OK in the main site. Would have been good to have had time to test before launch.

Also I'm seeing an error

ERROR/index/index.htmlexamples/js/jumpto.js' not found.`

This is seems to be saying the error in /index/index.html in is examples/js/jumpto.js not found (missing space)

The only ref to jump.js I find is in the external repo .../aria-practices/examples/js/app.js

@SteveALee SteveALee changed the title Files in /index [Required for Launch] Files in /index May 11, 2022
@SteveALee SteveALee added the question Further information is requested label May 11, 2022
@mcking65
Copy link
Contributor

mcking65 commented May 11, 2022

@richnoah

I don't know if this is related to our discussion yesterday, but I'd eventually like the URIs for the examples to be in examples directories that are children of the pattern directories.

For instance, for combobox examples, instead of the examples being in /index/ like this:

/index/combobox/combobox-autocomplete-both.html
/index/combobox/combobox-autocomplete-list.html
/index/combobox/combobox-autocomplete-none.html

I'd like the URI path to be /patterns/PATTERN_DIR/examples, like this:

/patterns/combobox/examples/combobox/combobox-autocomplete-both.html
/patterns/combobox/examples/combobox/combobox-autocomplete-list.html
/patterns/combobox/examples/combobox/combobox-autocomplete-none.html

This will help re-enforce the relationship between a pattern and its examples.

I don't want to require this for launch if it is a giant lift with a lot of potential side effects. However, we should do as soon as possible to avoid bookmark churn for users.

Let me know if this needs to be in a separate issue or if it is related to the issue @SteveALee is describing here.

@mcking65 mcking65 changed the title [Required for Launch] Files in /index Files in /index [Required for Launch] May 11, 2022
@SteveALee
Copy link
Contributor Author

FYI it occurred to me that the pattern source files could also be in in content/patterns/. But that's just my preference.

Jekyll is flexible and recurses down from content.

@richnoah
Copy link

@mcking65 yes, please create a separate issue for the URI work you mention. That would not be required for launch and would be a separate body of work. In speaking with Alex this would be a sizable lift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants