Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do with WebSockets #44

Open
joelweinberger opened this issue Sep 8, 2016 · 6 comments
Open

What to do with WebSockets #44

joelweinberger opened this issue Sep 8, 2016 · 6 comments
Milestone

Comments

@joelweinberger
Copy link
Contributor

I think we've discussed before that WebSockets should simply be disallowed. If that's the case, that should be explicitly added to the spec. If not, I assume we'll need to add Suborigin headers to requests. Either way, we need to spec out a solution.

@annevk
Copy link
Member

annevk commented Sep 8, 2016

Since you can polyfill WebSockets fairly soon, disallowing might be okay.

@kentonv
Copy link

kentonv commented Sep 8, 2016

For the Sandstorm use case[0], disallowing websockets would be pretty disappointing, as many of our apps use them extensively -- some without any fallback.

[0] https://docs.sandstorm.io/en/latest/administering/wildcard/#why-sandstorm-needs-wildcard-dns

@joelweinberger
Copy link
Contributor Author

Fair enough. If we disallowed it, I would consider that a temporary measure for v1 until we decided exactly what to do. @kentonv, do you have particular thoughts on how to work them into the spec today? Just put a Suborigin header in the request?

@kentonv
Copy link

kentonv commented Sep 8, 2016

I'm not very familiar with the spec, but it seems like the right solution is to include a Suborigin header, and for the Origin header to contain the "serialized suborigin value" as with CORS requests.

@devd
Copy link
Contributor

devd commented Sep 8, 2016

I think WebSockets can also be pretty easily faked using iframe based privilege separation: it sucks but I think for v1 we have to be pretty brutal about getting a MVP out and seeing how developers use it and what are the issues/problems using it. So, I am totally fine with punting it for v1.

@joelweinberger
Copy link
Contributor Author

Both in the spec and Chrome implementation, we've disabled WebSockets for v1. I'm leaving this issue open, though, and reclassifying it from bug to next-version so we can hopefully re-enable WebSockets in v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants