Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iojs: does not compile with io.js v2.0.0 #27

Closed
imyller opened this issue May 5, 2015 · 2 comments
Closed

iojs: does not compile with io.js v2.0.0 #27

imyller opened this issue May 5, 2015 · 2 comments

Comments

@imyller
Copy link

imyller commented May 5, 2015

With nan 1.7.0 and io.js 2.0.0 microtime does not compile:

In file included from ../src/microtime.cc:11:
In file included from ../node_modules/nan/nan.h:80:
In file included from ../node_modules/nan/nan_new.h:190:
../node_modules/nan/nan_implementation_12_inl.h:181:66: error: too many arguments to function call, expected at most 2, have 4
  return v8::Signature::New(v8::Isolate::GetCurrent(), receiver, argc, argv);
         ~~~~~~~~~~~~~~~~~~                                      ^~~~~~~~~~
/Users/-/.node-gyp/2.0.0/deps/v8/include/v8.h:4188:3: note: 'New' declared here
  static Local<Signature> New(
  ^

With nan 1.8.4 and io.js 2.0.0 microtime compiles, but gives deprecation warnings:

  CXX(target) Release/obj.target/microtime/src/microtime.o
../src/microtime.cc:51:36: warning: 'ErrnoException' is deprecated: Use UVException(isolate, ...) [-Wdeprecated-declarations]
        return NanThrowError(node::ErrnoException(errno, "gettimeofday"));
                                   ^
/Users/-/.node-gyp/2.0.0/src/node.h:81:45: note: 'ErrnoException' has been explicitly marked deprecated here
                inline v8::Local<v8::Value> ErrnoException(
                                            ^
/Users/-/.node-gyp/2.0.0/src/node.h:47:42: note: expanded from macro 'NODE_DEPRECATED'
    __attribute__((deprecated(message))) declarator

...

3 warnings generated.
  SOLINK_MODULE(target) Release/microtime.node
  SOLINK_MODULE(target) Release/microtime.node: Finished
@imyller
Copy link
Author

imyller commented May 5, 2015

Fixed in 1.4.0

@imyller imyller closed this as completed May 5, 2015
@wadey
Copy link
Owner

wadey commented May 5, 2015

1.4.1 fixes the deprecation warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants